Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK: Fix transaction decoding with boxes #422

Merged
merged 2 commits into from
Nov 9, 2022
Merged

SDK: Fix transaction decoding with boxes #422

merged 2 commits into from
Nov 9, 2022

Conversation

jasonpaulos
Copy link
Contributor

This PR fixes a bug when decoding transactions with box references. This SDK should now pass the test changes from algorand/algorand-sdk-testing#248

jasonpaulos
jasonpaulos commented Nov 8, 2022
View reviewed changes
.test-env Outdated Show resolved Hide resolved
@jasonpaulos jasonpaulos mentioned this pull request Nov 8, 2022
Merged
4 tasks
@jasonpaulos jasonpaulos requested a review from algochoi November 8, 2022 22:24
algochoi
algochoi approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice tests to check that we are copyOf a non-null value.

@jasonpaulos jasonpaulos marked this pull request as ready for review November 9, 2022 15:51
@jasonpaulos jasonpaulos merged commit d4e570e into develop Nov 9, 2022
@jasonpaulos jasonpaulos deleted the txn-box-decode-fix branch November 9, 2022 16:05
@excalq excalq mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi approved these changes

Assignees
No one assigned
Labels
Bug-Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonpaulos @algochoi