Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: Add algod block hash endpoint, add indexer block header-only param. #413

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

winder
Copy link
Contributor

@winder winder commented Oct 5, 2022

Add tests to generated code. See commits for the generated code vs the tests.

Tests are passing locally, CI is pending algorand/algorand-sdk-testing#245

@winder winder requested review from tzaffi and shiqizng October 5, 2022 03:41
@winder winder marked this pull request as draft October 5, 2022 03:54
@winder winder force-pushed the will/regenerate-sdk branch from 663fadd to 3bfd0eb Compare October 5, 2022 05:07
@winder winder self-assigned this Oct 5, 2022
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me. We should base the changes in the harness script off the definitive version of it in algorand/go-algorand-sdk#421

Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winder winder force-pushed the will/regenerate-sdk branch from 4690606 to 191643f Compare October 6, 2022 15:04
@winder winder changed the title Update client, add tests REST API: Add algod block hash endpoint, add indexer block header-only param. Oct 6, 2022
@winder winder marked this pull request as ready for review October 6, 2022 17:41
@winder winder merged commit 1541a2a into develop Oct 7, 2022
@winder winder deleted the will/regenerate-sdk branch October 7, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants