Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateProofs: Add State Proof support. #360

Merged
merged 9 commits into from
Aug 30, 2022
Merged

Conversation

winder
Copy link
Contributor

@winder winder commented Aug 16, 2022

Add support for new state proof endpoints and transaction deserialization.

@winder winder requested review from Eric-Warehime and id-ms August 16, 2022 00:20
@winder winder self-assigned this Aug 16, 2022
@winder winder requested a review from shiqizng August 16, 2022 11:55
@winder winder changed the title Add State Proof support. StateProofs: Add State Proof support. Aug 16, 2022
Comment on lines +169 to +173
@JsonProperty("sp")
public Map<String,Object> stateProof = null;

@JsonProperty("spmsg")
public Map<String,Object> stateProofMessage = null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types were really complicated, do they need to be added?

Copy link
Contributor

@shiqizng shiqizng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. Using BigInteger type seems odd to me.

README.md Outdated Show resolved Hide resolved
@id-ms
Copy link

id-ms commented Aug 18, 2022

think we should remove the old v2/client/algod/GetProof.java file since the endpoint was renamed

@winder winder requested a review from id-ms August 18, 2022 20:35
@winder winder force-pushed the will/state-proof-support branch from 10726d7 to 29c6e6e Compare August 29, 2022 17:44
@id-ms id-ms merged commit be204c1 into develop Aug 30, 2022
@winder winder deleted the will/state-proof-support branch August 30, 2022 16:58
ahangsu added a commit that referenced this pull request Sep 2, 2022
* Ignore copied over txt test resource files (#342)

* Github-Actions: Adding pr title and label checks (#339)

* Enhancement: Add UNKNOWN enum type to HTTP client enums. (#351)

* AVM:  Consolidate TEAL and AVM versions (#348)

* Testing: Modify cucumber steps to use dev mode network  (#350)

* DevTools: adding source map decoder (#352)

* adding source map decoder

* bump to 1.17.0

* Enhancement: Use Sandbox for Testing (#363)

* Bugfix: Pass verbosity to the harness and sandbox (#371)

* Enhancement: Deprecating use of langspec (#367)

Co-authored-by: Michael Diamant <[email protected]>

* StateProofs: Add State Proof support. (#360)

* Regenerate client.

* Implement cucumber response tests.

* Implement path tests, update Makefile, update README.

* Revert

* Add state proof fields to Transaction.

* Update README.md

* Update src/main/java/com/algorand/algosdk/transaction/Transaction.java

* publish results.

* Add transaction-root-256

* dummy commit to avoid check pr category

* dummy commit to kill previous dummy commit

Co-authored-by: Michael Diamant <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Will Winder <[email protected]>
Co-authored-by: Ben Guidarelli <[email protected]>
Co-authored-by: Barbara Poon <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants