Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate updated client API code #318

Merged
merged 7 commits into from
Jun 2, 2022
Merged

Generate updated client API code #318

merged 7 commits into from
Jun 2, 2022

Conversation

algoidurovic
Copy link
Contributor

@algoidurovic algoidurovic requested a review from jasonpaulos May 11, 2022 19:10
ahangsu
ahangsu reviewed May 12, 2022
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems right, but I didn't see a generator PR.

The error build message also seems off, the indexer build failed?

Now it seems we need to remove references to the old cost field in current implementation.

ahangsu
ahangsu approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, waiting on Jason's review

jasonpaulos
jasonpaulos reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a note about TEAL disassembly, but other than that this looks good

src/main/java/com/algorand/algosdk/v2/client/algod/TealDisassemble.java Outdated Show resolved Hide resolved
@michaeldiamant michaeldiamant mentioned this pull request May 13, 2022
Closed
@algoidurovic algoidurovic merged commit 0ed5109 into algorand:develop Jun 2, 2022
@onetechnical onetechnical mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahangsu ahangsu ahangsu approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algoidurovic @jasonpaulos @ahangsu