Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(release): add support for conduit #1330

Merged
merged 4 commits into from
Nov 16, 2022
Merged

misc(release): add support for conduit #1330

merged 4 commits into from
Nov 16, 2022

Conversation

algolucky
Copy link
Contributor

@algolucky algolucky commented Nov 15, 2022 •
edited
Loading

Summary

  • this updates the release.py script to support building conduit
  • changes python requirement of e2e_tests to >=3.8 since 3.8.10 is what's installed in CI, otherwise installation fails

Test Plan

  • execute make fakepackage locally

@algolucky algolucky self-assigned this Nov 15, 2022
@algolucky algolucky marked this pull request as ready for review November 15, 2022 20:33
@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

Merging #1330 (36e61c2) into conduit (c0e1146) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           conduit    #1330      +/-   ##
===========================================
- Coverage    60.68%   60.66%   -0.03%     
===========================================
  Files           76       76              
  Lines        10913    10913              
===========================================
- Hits          6623     6620       -3     
- Misses        3703     3705       +2     
- Partials       587      588       +1
Impacted Files Coverage Δ
idb/postgres/postgres.go 64.71% <0.00%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algobarb
algobarb approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok

@algolucky algolucky merged commit b343cae into algorand:conduit Nov 16, 2022
@algolucky algolucky deleted the add-conduit-release-support branch November 16, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiqizng shiqizng shiqizng approved these changes

@algobarb algobarb algobarb approved these changes

@Eric-Warehime Eric-Warehime Eric-Warehime approved these changes

@excalq excalq Awaiting requested review from excalq excalq was automatically assigned from algorand/devops

@algojack algojack Awaiting requested review from algojack algojack was automatically assigned from algorand/devops

@AlgoStephenAkiki AlgoStephenAkiki Awaiting requested review from AlgoStephenAkiki

@winder winder Awaiting requested review from winder

Assignees

@algolucky algolucky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@algolucky @Eric-Warehime @algobarb @shiqizng