Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize plugin packages. #1317

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Conversation

winder
Copy link
Contributor

@winder winder commented Nov 6, 2022

Summary

Nonfunctional changes, move all plugin packages under a common conduit package.

While moving things around I noticed that we have a lot of things named Metadata and Config. I'd like to find some better names and places for these things so that there are fewer things to pick from when implementing a new plugin.

Test Plan

CI

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #1317 (1a890db) into conduit (9214b07) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           conduit    #1317   +/-   ##
========================================
  Coverage    60.68%   60.68%           
========================================
  Files           76       76           
  Lines        10913    10913           
========================================
  Hits          6623     6623           
  Misses        3703     3703           
  Partials       587      587           
Impacted Files Coverage Δ
conduit/config.go 85.71% <ø> (ø)
conduit/pipeline/metadata.go 100.00% <ø> (ø)
conduit/pipeline/pipeline.go 65.67% <ø> (ø)
...duit/plugins/exporters/example/example_exporter.go 80.00% <ø> (ø)
conduit/plugins/exporters/exporter_factory.go 100.00% <ø> (ø)
...duit/plugins/exporters/filewriter/file_exporter.go 83.33% <ø> (ø)
conduit/plugins/exporters/noop/noop_exporter.go 70.83% <ø> (ø)
...lugins/exporters/postgresql/postgresql_exporter.go 80.23% <ø> (ø)
conduit/plugins/exporters/postgresql/util/prune.go 75.00% <ø> (ø)
conduit/plugins/importers/algod/algod_importer.go 78.02% <ø> (ø)
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review November 7, 2022 13:59
@winder winder merged commit c0e1146 into algorand:conduit Nov 7, 2022
@winder winder deleted the will/plugins-package branch November 7, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants