Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduit: fix e2e_conduit #1301

Merged
merged 1 commit into from
Nov 1, 2022
Merged

conduit: fix e2e_conduit #1301

merged 1 commit into from
Nov 1, 2022

Conversation

shiqizng
Copy link
Contributor

@shiqizng shiqizng commented Nov 1, 2022

Summary

This PR adds a parameter for specifying e2e_conduit test artifact and updates tar path parsing

Test Plan

How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.

@shiqizng shiqizng self-assigned this Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1301 (c7ac6d7) into conduit (8f165aa) will increase coverage by 0.36%.
The diff coverage is 62.50%.

@@             Coverage Diff             @@
##           conduit    #1301      +/-   ##
===========================================
+ Coverage    58.68%   59.04%   +0.36%     
===========================================
  Files           78       78              
  Lines        10507    10507              
===========================================
+ Hits          6166     6204      +38     
+ Misses        3804     3758      -46     
- Partials       537      545       +8     
Impacted Files Coverage Δ
conduit/pipeline.go 64.97% <62.50%> (+8.88%) ⬆️
importers/importer_factory.go 50.00% <0.00%> (+25.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shiqizng shiqizng merged commit 388d00b into conduit Nov 1, 2022
@winder winder deleted the fix/e2e branch November 2, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants