Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduit: plugin constructor #1298

Merged
merged 4 commits into from
Nov 1, 2022
Merged

conduit: plugin constructor #1298

merged 4 commits into from
Nov 1, 2022

Conversation

shiqizng
Copy link
Contributor

Summary

refactoring plugin constructor to reduce boilerplate code

Test Plan

update unit tests

@shiqizng shiqizng self-assigned this Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1298 (1dc2ca7) into conduit (bd5a482) will decrease coverage by 0.14%.
The diff coverage is 21.21%.

@@             Coverage Diff             @@
##           conduit    #1298      +/-   ##
===========================================
- Coverage    58.82%   58.67%   -0.15%     
===========================================
  Files           78       78              
  Lines        10490    10496       +6     
===========================================
- Hits          6171     6159      -12     
- Misses        3786     3796      +10     
- Partials       533      541       +8     
Impacted Files Coverage Δ
exporters/example/example_exporter.go 65.00% <0.00%> (-15.00%) ⬇️
exporters/filewriter/file_exporter.go 77.77% <0.00%> (-5.56%) ⬇️
exporters/noop/noop_exporter.go 58.33% <0.00%> (-12.51%) ⬇️
exporters/postgresql/postgresql_exporter.go 76.74% <0.00%> (-3.49%) ⬇️
importers/algod/algod_importer.go 78.16% <0.00%> (-1.15%) ⬇️
importers/filereader/filereader.go 84.37% <0.00%> (-1.57%) ⬇️
importers/importer_factory.go 21.42% <0.00%> (-3.58%) ⬇️
processors/blockprocessor/block_processor.go 64.22% <0.00%> (-0.44%) ⬇️
processors/noop/noop_processor.go 7.14% <0.00%> (-7.15%) ⬇️
exporters/exporter_factory.go 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the handler func's next to the constructor functions in the *_factory.go files?

Other than this, the changes look good.

@shiqizng shiqizng requested a review from winder October 31, 2022 20:05
@shiqizng shiqizng merged commit 84e2f12 into conduit Nov 1, 2022
@winder winder deleted the shiqi/constructor branch November 3, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants