Conduit: Dynamic on complete #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiqizng
approved these changes
Oct 20, 2022
| @@ -158,6 +160,20 @@ func (p *pipelineImpl) setError(err error) { | |||
| p.err = err | |||
| } | |||
|
|
|||
| func (p *pipelineImpl) registerLifecycleCallbacks() { | |||
| if v, ok := (*p.importer).(Completed); ok { | |||
winder
commented
Oct 20, 2022
conduit/pipeline.go
Outdated
Comment on lines
143
to
146
| importer *importers.Importer | ||
| processors []*processors.Processor | ||
| exporter *exporters.Exporter | ||
| completeCallback []Completed |
There was a problem hiding this comment.
I'm not sure if this needs to be []*Completed or not. I think all of our plugins use pointer receivers, so they are already pointers, but maybe that isn't always the case.
winder
force-pushed
the
will/dynamic-on-complete
branch
from
9777d4a to
4b1ca63
Compare
Eric-Warehime
approved these changes
Oct 21, 2022
|
Looks like the lint is failing, but otherwise really cool refactoring! |
winder
force-pushed
the
will/dynamic-on-complete
branch
from
92ce73c to
c9c4cee
Compare
Codecov Report
@@ Coverage Diff @@
## conduit #1285 +/- ##
===========================================
+ Coverage 60.24% 60.31% +0.07%
===========================================
Files 76 76
Lines 10034 10042 +8
===========================================
+ Hits 6045 6057 +12
+ Misses 3463 3459 -4
Partials 526 526
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seemed like this function is useful to any plugin, so I have implemented it in a dynamic way.
Any plugin can now add an
OnCompletecallback if they need it, and do not need to provide it if they do not.Test Plan
Update tests.