Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to naming #1279

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Conversation

AlgoStephenAkiki
Copy link
Contributor

Resolves #1263

Changed config and variable naming conventions

Summary

Explain the goal of this change and what problem it is solving. Format this cleanly so that it may be used for a commit message, as your changes will be squash-merged.

Test Plan

How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.

Resolves #1263

Changed config and variable naming conventions
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #1279 (40ebaf7) into conduit (6a6fd87) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           conduit    #1279   +/-   ##
========================================
  Coverage    60.12%   60.12%           
========================================
  Files           74       74           
  Lines         9917     9917           
========================================
  Hits          5963     5963           
  Misses        3436     3436           
  Partials       518      518           
Impacted Files Coverage Δ
conduit/pipeline.go 52.50% <ø> (ø)
exporters/filewriter/file_exporter.go 64.40% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder merged commit d7c2365 into conduit Oct 19, 2022
@winder winder deleted the 1263-conduit-config-variable-naming-conventions branch October 19, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants