Conduit: filereader / filewriter plugins and compatibility changes. #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## conduit #1253 +/- ##
===========================================
+ Coverage 58.39% 58.72% +0.32%
===========================================
Files 77 78 +1
Lines 10332 10463 +131
===========================================
+ Hits 6033 6144 +111
- Misses 3772 3786 +14
- Partials 527 533 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
commented
Oct 3, 2022
Comment on lines
+68
to
+71
| err := os.MkdirAll(dataDir, 0755) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("MakeProcessor() failed to create '%s': %w", dataDir, err) | ||
| } |
There was a problem hiding this comment.
Automatically create the local ledger directory if it's missing. While I was testing different configurations, this kept coming up.
winder
commented
Oct 3, 2022
| @@ -185,8 +197,10 @@ func (exp *fileExporter) Round() uint64 { | |||
| return exp.round | |||
| } | |||
|
|
|||
| func (exp *fileExporter) unmarhshalConfig(cfg string) error { | |||
| return yaml.Unmarshal([]byte(cfg), &exp.cfg) | |||
| func unmarshalConfig(cfg string) (Config, error) { | |||
There was a problem hiding this comment.
Contender for generics right here, we have the same function (with the same typo) in lots of places. I turned it into a pure function in a few places.
winder
commented
Oct 3, 2022
Comment on lines
184
to
187
| genesisFilename := path.Join(exp.cfg.BlocksDir, "genesis.json") | ||
| if err := util.EncodeToFile(genesisFilename, genesis, true); err != nil { | ||
| return fmt.Errorf("HandleGenesis() failed to serialize genesis file: %w", err) | ||
| } |
There was a problem hiding this comment.
File reader needs the genesis file.
winder
changed the title
shiqizng
approved these changes
Oct 21, 2022
This reverts commit 10fa5ac.
shiqizng
reviewed
Oct 26, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
StateDeltaobject contains a map with non-string keys which caused a problem with the json encoder.Test Plan
New unit tests.