Add panic recovers #1251
Merged
Add panic recovers #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #263 Adds recovery functions in main loop of conduit as well as in a go-routine in the start function of the pipeline
Codecov Report
@@ Coverage Diff @@
## conduit #1251 +/- ##
===========================================
- Coverage 62.06% 62.05% -0.01%
===========================================
Files 70 71 +1
Lines 9434 9440 +6
===========================================
+ Hits 5855 5858 +3
- Misses 3073 3075 +2
- Partials 506 507 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
reviewed
Sep 29, 2022
cmd/conduit/main.go
Outdated
Comment on lines
53
to
57
| defer func() { | ||
| if r := recover(); r != nil { | ||
| logger.Fatalf("conduit framework experienced a panic: %v", r) | ||
| } | ||
| }() |
There was a problem hiding this comment.
Do you think it's worth making a helper function? I'm thinking that could be something we document / reuse in plugins.
func HandlePanicAndFail(logger *log.Logger) {
if r := recover(); r != nil {
logger.Panicf("conduit framework experienced a panic: %v", r)
}
}
Also, it looks like logrus has a "Panic" level. The difference compared to Fatal is that it calls panic after logging instead of Exit.
There was a problem hiding this comment.
Re-worked, let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #263
Adds recovery functions in main loop of conduit as well as in a go-routine in the start function of the pipeline
Summary
Explain the goal of this change and what problem it is solving. Format this cleanly so that it may be used for a commit message, as your changes will be squash-merged.
Test Plan
How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.