Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Exporter: fixes for simple configuration #1232

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

winder
Copy link
Contributor

@winder winder commented Sep 21, 2022

Summary

Testing with a simple configuration wasn't working quite right:

Importer:
    Name: algod
    Config:
      - netaddr: {mainnet node addr}
        token: {token}
Exporter:
    Name: filewriter
    Config:
      - block-dir: {path}/data2/blocks
  1. encoding failed when pointed to mainnet.
  2. the metadata file was not being updated, leading to re-downloading the same blocks.

@winder winder changed the base branch from develop to conduit September 21, 2022 17:11
@winder winder force-pushed the will/conduit-init-command branch from cece3fa to 7e8ac4d Compare September 21, 2022 17:12
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1232 (214b5f7) into conduit (7cf43e8) will decrease coverage by 0.05%.
The diff coverage is 52.50%.

@@             Coverage Diff             @@
##           conduit    #1232      +/-   ##
===========================================
- Coverage    62.11%   62.06%   -0.06%     
===========================================
  Files           70       70              
  Lines         9408     9434      +26     
===========================================
+ Hits          5844     5855      +11     
- Misses        3063     3073      +10     
- Partials       501      506       +5     
Impacted Files Coverage Δ
exporters/filewriter/file_exporter.go 64.40% <52.50%> (-6.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review September 21, 2022 18:08
@winder winder mentioned this pull request Sep 21, 2022
@winder winder merged commit ce54ff3 into algorand:conduit Sep 26, 2022
@winder winder deleted the will/conduit-init-command branch September 26, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants