-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom consensus on private networks #1041
Conversation
Hi, I'm not sure if I can see what this would do since block data in the indexer is imported independent of the consensus process. Can you give me a bit of background on why you might need this change? |
sure, algod loads correctly custom consensus from consensus.json file. but there is no way to use custom consensus with the indexer.. the indexer without this bugfix fails here Line 27 in 5be3c0e
if you want, you can find the way to load consensus from the algod server, but right now you are using hardcoded consensus values with no option to extend it.. this PR is simple fix to resolve the issue with ability to provide consensus.json file with the indexer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just need to fix the fmt issue
Thanks for explaining, @scholtz 😁 |
Co-authored-by: Eric Warehime <[email protected]>
Co-authored-by: Eric Warehime <[email protected]>
Summary
Algorand indexer at the moment does not allow using custom consensus on private networks. This pull request adds this feature.
Test Plan
I tested it manually on custom made private network with custom consensus.