-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Ledger Deployment #1013
Local Ledger Deployment #1013
Conversation
Codecov Report
@@ Coverage Diff @@
## localledger/integration #1013 +/- ##
==========================================================
Coverage ? 59.54%
==========================================================
Files ? 47
Lines ? 8654
Branches ? 0
==========================================================
Hits ? 5153
Misses ? 3017
Partials ? 484 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it should work. I think it's diverged a little from the first PR.
AlgodDataDir string | ||
AlgodToken string | ||
AlgodAddr string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically AlgodDataDir
resolves to AlgodToken
/ AlgodAddr
, so we could remove AlgodDataDir
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought both were needed since there are 2 ways for the fetcher to create an algod client,
indexer/idb/postgres/internal/migrations/local_ledger/migration.go
Lines 50 to 63 in df6bcb6
// create algod client | |
if opts.AlgodDataDir != "" { | |
bot, err = fetcher.ForDataDir(opts.AlgodDataDir, logger) | |
if err != nil { | |
return fmt.Errorf("RunMigration() err: %w", err) | |
} | |
} else if opts.AlgodAddr != "" && opts.AlgodToken != "" { | |
bot, err = fetcher.ForNetAndToken(opts.AlgodAddr, opts.AlgodToken, logger) | |
if err != nil { | |
return fmt.Errorf("RunMigration() err: %w", err) | |
} | |
} else { | |
return fmt.Errorf("RunMigration() err: unable to create algod client") | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ForDataDir
would do something like resolve the address/token and then call ForNetAndToken
idb/postgres/internal/migrations/local_ledger/migration_test.go
Outdated
Show resolved
Hide resolved
idb/postgres/internal/migrations/local_ledger/migration_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Local Ledger (#1011) * integrate block processor * Local Ledger Deployment (#1013) * add simple local ledger migration * add deleted opts * fast catchup (#1023) * add fast catchup * Localledger merge (#1036) * return empty lists from fetchApplications and fetchAppLocalStates (#1010) * Update model to converge with algod (#1005) * New Feature: Adds Data Directory Support (#1012) - Updates the go-algorand submodule hash to point to rel/beta - Moves the cpu profiling file, pid file and indexer configuration file to be options of only the daemon sub-command - Changes os.Exit() to be a panic with a special handler. This is so that defer's are handled instead of being ignored. - Detects auto-loading configuration files in the data directory and issues errors if equivalent command line arguments are supplied. - Updates the README with instructions on how to use the auto-loading configuration files and the data directory. * Update mockery version Co-authored-by: erer1243 <[email protected]> Co-authored-by: AlgoStephenAkiki <[email protected]> * recovery scenario (#1024) * handle ledger recovery scenario * refactor create genesis block (#1026) * refactor create genesis block * Adds Local Ledger Readme (#1035) * Adds Local Ledger Readme Resolves #4109 Starts Readme docs * Update docs/LocalLedger.md Co-authored-by: Will Winder <[email protected]> * Update docs/LocalLedger.md Co-authored-by: Will Winder <[email protected]> * Update docs/LocalLedger.md Co-authored-by: Will Winder <[email protected]> * Removed troubleshooting section Co-authored-by: Will Winder <[email protected]> * update ledger file path and migration (#1042) * LocalLedger Refactoring + Catchpoint Service (#1049) Part 1 cleanup genesis file access. put node catchup into a function that can be swapped out with the catchup service. pass the indexer logger into the block processor. move open ledger into a util function, and move the initial state util function into a new ledger util file. add initial catchupservice implementation. move ledger init from daemon.go to constructor. Merge multiple read genesis functions. Part 2 Merge local_ledger migration package into blockprocessor. Rename Migration to Initialize Use logger in catchup service catchup Part 3 Update submodule and use NewWrappedLogger. Make util.CreateInitState private * build: merge develop into localledger/integration (#1062) * Ledger init status (#1058) * Generate an error if the catchpoint is not valid for initialization. (#1075) * Use main logger in handler and fetcher. (#1077) * Switch from fullNode catchup to catchpoint catchup service. (#1076) * Refactor daemon, add more tests (#1039) Refactors daemon cmd into separate, testable pieces. * Merge develop into localledger/integration (#1083) * Misc Local Ledger cleanup (#1086) * Update processor/blockprocessor/initialize.go Co-authored-by: Zeph Grunschlag <[email protected]> * commit * fix function call args * RFC-0001: Rfc 0001 impl (#1069) Adds an Exporter interface and a noop exporter implementation with factory methods for construction * Fix test errors * Add/fix tests * Add postgresql_exporter tests * Update config loading * Change BlockExportData to pointers * Move and rename ExportData * Add Empty func to BlockData * Add comment Co-authored-by: shiqizng <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: erer1243 <[email protected]> Co-authored-by: AlgoStephenAkiki <[email protected]> Co-authored-by: Will Winder <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]>
Summary
This PR adds a simple migration process for local ledger. Migration completes when latest round in ledger matches the round in postgres db. Indexer exits with code 1 if SIGTERM or SIGINT is received during the migration. When indexer restarts, ledger migration continues from round
ledger.latest()+1
.Test Plan
Unit tests for the core migration logic in
RunMigration
. Run a migration on a remote server using a mainnet db snapshot.