Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchpoints: log ledger download failures #6227

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

cce
Copy link
Contributor

@cce cce commented Jan 10, 2025

Summary

I noticed we have logging around catchpoint ledger file download success, and catchpoint block download errors, but no logging for catchpoint ledger file download failures. This provides more logging about failures related to ledger file timeout & retry issues like those seen with #5503.

Test Plan

Logging only changes, existing tests should pass.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.83%. Comparing base (c60db8d) to head (b7aeb40).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
catchup/catchpointService.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6227      +/-   ##
==========================================
- Coverage   51.86%   51.83%   -0.04%     
==========================================
  Files         643      643              
  Lines       86382    86384       +2     
==========================================
- Hits        44804    44774      -30     
- Misses      38716    38740      +24     
- Partials     2862     2870       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cce cce merged commit 023a686 into algorand:master Jan 13, 2025
19 of 20 checks passed
@cce cce deleted the catchpoint-log-download-failures branch January 13, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants