tests: add catchpoint downloading/parsing to e2e catchup tests #6224
+260
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on #6214 and #6177, it would have been nice to be able to download catchpoint files and decode them inside E2E tests. This exports the catchpoint chunk formats (and msgp unmarshal code), so they can be used by the e2e tests to decode and assert catchpoint file snapshot contents.
While renaming the chunk types so they would be exported, their new names were carefully chosen to preserve alphabetical ordering and make the diff in msgp_gen.go easy to review (to see it is a name change only, no other changes to decode/encode logic).
Test Plan
Existing E2E tests should pass, with additional assertions added.