Tests: Minimize flakiness in TestBasicPayouts #6211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flakiness seemed to come from one of two places 1) Testing balances after a proposal as sometimes wrong, if the proposer proposed AGAIN before we performed the checks. 2) An off by one error such that if account01 (which proposed rarely) proposed in exactly the lookback'th round after burning algos, we thought it should not get paid, but it should.
jannotti
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6211 +/- ##
==========================================
- Coverage 51.92% 51.91% -0.01%
==========================================
Files 643 643
Lines 86240 86240
==========================================
- Hits 44779 44774 -5
- Misses 38598 38599 +1
- Partials 2863 2867 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flakiness seemed to come from one of two places
Testing balances after a proposal as sometimes wrong, if the proposer proposed AGAIN before we performed the checks.
An off by one error such that if account01 (which proposed rarely) proposed in exactly the lookback'th round after burning algos, we thought it should not get paid, but it should.
Summary
Test Plan