Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec4 fixup #6209

Closed
wants to merge 11 commits into from
Closed

Spec4 fixup #6209

wants to merge 11 commits into from

Conversation

jannotti
Copy link
Contributor

Summary

Test Plan

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 57.44681% with 20 lines in your changes missing coverage. Please review.

Project coverage is 51.93%. Comparing base (a10b6b3) to head (0ec1739).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ledger/store/trackerdb/sqlitedriver/kvsIter.go 0.00% 10 Missing ⚠️
...edger/store/trackerdb/sqlitedriver/sqlitedriver.go 0.00% 4 Missing ⚠️
ledger/catchupaccessor.go 33.33% 2 Missing ⚠️
ledger/store/trackerdb/dualdriver/dualdriver.go 0.00% 2 Missing ⚠️
ledger/store/trackerdb/generickv/reader.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6209      +/-   ##
==========================================
+ Coverage   50.93%   51.93%   +1.00%     
==========================================
  Files         643      643              
  Lines       86223    86234      +11     
==========================================
+ Hits        43915    44785     +870     
+ Misses      39433    38590     -843     
+ Partials     2875     2859      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants