-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eval: Feature/heartbeats #6189
Merged
Merged
Eval: Feature/heartbeats #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ticipationAccounts (#6085) Co-authored-by: John Jannotti <[email protected]>
…AccountData when rnd < 240 (#6165)
Co-authored-by: Gary Malouf <[email protected]>
cce
reviewed
Dec 4, 2024
cce
reviewed
Dec 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6189 +/- ##
==========================================
+ Coverage 51.88% 52.00% +0.11%
==========================================
Files 639 642 +3
Lines 85489 85834 +345
==========================================
+ Hits 44359 44635 +276
- Misses 38320 38362 +42
- Partials 2810 2837 +27 ☔ View full report in Codecov by Sentry. |
jannotti
force-pushed
the
feature/heartbeats
branch
from
December 5, 2024 20:23
0fe2ef2
to
cab07e3
Compare
gmalouf
requested review from
cce,
yossigi,
algorandskiy,
zeldovich and
gmalouf
December 11, 2024 19:37
And include tests that !IncentiveEligible accounts won't be suspended, despite lack of heartbeat.
gmalouf
reviewed
Dec 12, 2024
yossigi
previously approved these changes
Dec 19, 2024
zeldovich
previously approved these changes
Dec 19, 2024
gmalouf
previously approved these changes
Dec 19, 2024
cce
reviewed
Dec 19, 2024
cce
reviewed
Dec 19, 2024
cce
previously approved these changes
Dec 19, 2024
zeldovich
approved these changes
Dec 19, 2024
gmalouf
reviewed
Dec 19, 2024
gmalouf
approved these changes
Dec 19, 2024
cce
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR to put heartbeats into main. The new heartbeats/README.md is the best place to look for explaining it.