-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: fan in incoming txns into backlog worker #6126
Open
algorandskiy
wants to merge
7
commits into
algorand:master
Choose a base branch
from
algorandskiy:pavel/p2p-txhander-bg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6126 +/- ##
==========================================
- Coverage 56.25% 56.25% -0.01%
==========================================
Files 494 494
Lines 69946 69950 +4
==========================================
- Hits 39350 39347 -3
- Misses 27919 27925 +6
- Partials 2677 2678 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/p2p-txhander-bg
branch
4 times, most recently
from
September 20, 2024 18:54
a65acca
to
2e055ca
Compare
algorandskiy
changed the title
WIP: p2p: fan in incoming txns into backlog worker
p2p: fan in incoming txns into backlog worker
Sep 21, 2024
algorandskiy
force-pushed
the
pavel/p2p-txhander-bg
branch
from
September 27, 2024 14:46
5759b58
to
5635798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While investigating p2p TX traffic and performance, I found transaction pool mutex congestion. This PR is a PoC to use
backlogWorker
as a pool only accessor similarly to wsnet.Implementation summary:
syncCh
channel to work itemwi
syncCh
is initiated and awaited making validation synchronous as before.backlogWorker
checks ifsyncCh
is set and responds with validation result to the channel.Additionally, there are couple more fixes that helped with TPS as well:
sub.Next()
faster.Test Plan