-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Provide access to some more block header values #6107
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6107 +/- ##
==========================================
- Coverage 56.27% 56.27% -0.01%
==========================================
Files 490 490
Lines 69710 69720 +10
==========================================
+ Hits 39230 39234 +4
- Misses 27817 27819 +2
- Partials 2663 2667 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I did want to call attention to the change in values for the other v11 block fields
e3ae2ee
to
4fdcff6
Compare
Because of block incentives, there are good reasons to expose the FeeSink and the ProposerPayout from the block header to AVM using the block opcode. While doing that, we can consider a few more things that might be useful.
Currently this PR exposes these.