p2p: get rid of interface{} from PeerStore methods #6101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At some point
PeerStore
was though to implementPhonebook
interface, and as part of this some methods hadinterface{}
in signature to accommodate bothstring
andpeer.AddrInfo
. It ended up exact interface match not needed so I'm reverting thisinterface{}
workaround.Actually it is possible to keep
addr []string
inAddPersistentPeers
andReplacePeerList
since they operate on single-addressAddrInfo
so string toAddrInfo
conversion is possible.In the same time
GetAddresses
returns slice of either strings (Phonebook
) or generic learnedpeer.AddrInfo
from the underlying peerstore, and no multiple addr to string conversion possible.Test Plan
Existing tests to pass