p2p: do not register closing peer #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6086 +/- ##
==========================================
+ Coverage 55.95% 56.26% +0.31%
==========================================
Files 488 488
Lines 69602 69606 +4
==========================================
+ Hits 38945 39164 +219
+ Misses 27967 27787 -180
+ Partials 2690 2655 -35 ☔ View full report in Codecov by Sentry. |
cce
reviewed
Jul 29, 2024
Co-authored-by: cce <[email protected]>
cce
approved these changes
Jul 29, 2024
jasonpaulos
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a possible race condition between starting a new wsPeer (that starts reading/writing goroutines), and registering this peer in
wsPeersmap.wsNetwork.addPeerhad such check butp2pNetwork.wsStreamHandlermissed it. See failed test logs for demo.Additionally fixed asserts in catchup tests - on an error they were logging incorrect error object.
Test Plan
Discovered by a test added in #6082