-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: update nightly builds to use universal mac update #6071
CI: update nightly builds to use universal mac update #6071
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6071 +/- ##
==========================================
- Coverage 56.13% 56.11% -0.02%
==========================================
Files 488 488
Lines 69439 69445 +6
==========================================
- Hits 38978 38968 -10
- Misses 27813 27823 +10
- Partials 2648 2654 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one remark about naked return stmt.
Co-authored-by: Pavel Zbitskiy <[email protected]>
Summary
In #6023 we added a universal mac build target. We should switch to this as it's a simplified model for handling Mac binaries. This PR takes the first step by migrating our nightly builds to use this by default.
Note that I did not want to just make Mac universal builds the default for
make build
. It does, however, presume if you runmake universal
that you want that as your primary binary.Also removed arm32 from the updater script, as that platform support has been deprecated.
Test Plan
Been running steps individually, but will also need to see if nightly build/promotion works.