Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: disable TestP2PRelay on CI #6059

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Jul 8, 2024

Summary

Attempts to debug failures of TestP2PRelay as well as hardening startup checks have not stabilized the test on CI.
After adding pubsub traces there were no single failure in 7 runs in a row, so disabling this test as further debugging starts looking as a waste of time.

Also enabled debug logging in TestVotersReloadFromDiskAfterOneStateProofCommitted since it fails time to time.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.83%. Comparing base (a9641a3) to head (6af46df).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6059      +/-   ##
==========================================
- Coverage   56.16%   55.83%   -0.33%     
==========================================
  Files         488      488              
  Lines       69432    69432              
==========================================
- Hits        38995    38770     -225     
- Misses      27792    27983     +191     
- Partials     2645     2679      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy requested review from cce and gmalouf July 9, 2024 16:36
gmalouf
gmalouf previously approved these changes Jul 9, 2024
cce
cce previously approved these changes Jul 9, 2024
@algorandskiy algorandskiy dismissed stale reviews from cce and gmalouf via 796a416 July 9, 2024 20:03
network/p2p/pubsub.go Outdated Show resolved Hide resolved
@algorandskiy algorandskiy changed the title tests: enable debug logging in TestP2PRelay tests: disable TestP2PRelay on CI Jul 10, 2024
@algorandskiy algorandskiy requested review from gmalouf and cce July 10, 2024 14:57
Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any other coverage for the cases being disabled?

@algorandskiy
Copy link
Contributor Author

yes, there is TestP2PSubmitTX that checks pubsub as well. This test is more about config parameter enabling Relay method (NetAddress set). In this sense there is no other such tests.

@algorandskiy algorandskiy merged commit b46e2c1 into algorand:master Jul 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants