-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: disable TestP2PRelay on CI #6059
tests: disable TestP2PRelay on CI #6059
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6059 +/- ##
==========================================
- Coverage 56.16% 55.83% -0.33%
==========================================
Files 488 488
Lines 69432 69432
==========================================
- Hits 38995 38770 -225
- Misses 27792 27983 +191
- Partials 2645 2679 +34 ☔ View full report in Codecov by Sentry. |
This reverts commit 796a416.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any other coverage for the cases being disabled?
yes, there is |
Summary
Attempts to debug failures of
TestP2PRelay
as well as hardening startup checks have not stabilized the test on CI.After adding pubsub traces there were no single failure in 7 runs in a row, so disabling this test as further debugging starts looking as a waste of time.
Also enabled debug logging in
TestVotersReloadFromDiskAfterOneStateProofCommitted
since it fails time to time.