Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: increase ListPeersForTopic wait time in TestP2PRelay #6056

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

TestP2PRelay failures (one, two) indicate netC messages get lost. Most likely it is not enough time for pubsub to establish its mesh so increased wait time to stabilize the test.

Test Plan

This is a test fix

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.15%. Comparing base (b3c7bca) to head (1cb8326).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6056      +/-   ##
==========================================
- Coverage   56.21%   56.15%   -0.06%     
==========================================
  Files         488      488              
  Lines       69432    69432              
==========================================
- Hits        39030    38990      -40     
- Misses      27761    27789      +28     
- Partials     2641     2653      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit 046d01d into algorand:master Jul 8, 2024
18 of 19 checks passed
@algorandskiy algorandskiy deleted the pavel/p2p-pubsub-test-fix branch July 8, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants