Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Expose relevant incentive constants #6025

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Jun 11, 2024

Create global constants for some of the protocol constants introduced with the block incentive mechanism.

Resolves #5998

@jannotti jannotti requested review from gmalouf and jasonpaulos June 11, 2024 17:35
@jannotti jannotti self-assigned this Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.97%. Comparing base (fe78417) to head (13038d4).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6025      +/-   ##
==========================================
+ Coverage   55.96%   55.97%   +0.01%     
==========================================
  Files         482      482              
  Lines       68287    68297      +10     
==========================================
+ Hits        38214    38228      +14     
+ Misses      27476    27474       -2     
+ Partials     2597     2595       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmalouf
gmalouf previously approved these changes Jun 11, 2024
Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very straightforward to me, left nit(s) and question.

data/transactions/logic/fields.go Outdated Show resolved Hide resolved
data/transactions/logic/fields.go Show resolved Hide resolved
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maximum typo should be corrected, but otherwise this looks good

data/transactions/logic/assembler_test.go Show resolved Hide resolved
data/transactions/logic/fields.go Outdated Show resolved Hide resolved
@gmalouf gmalouf merged commit 4caf2e4 into algorand:master Jun 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add access to incentive related consensus parameters
3 participants