-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Expose relevant incentive constants #6025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6025 +/- ##
==========================================
+ Coverage 55.96% 55.97% +0.01%
==========================================
Files 482 482
Lines 68287 68297 +10
==========================================
+ Hits 38214 38228 +14
+ Misses 27476 27474 -2
+ Partials 2597 2595 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very straightforward to me, left nit(s) and question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The maximum typo should be corrected, but otherwise this looks good
Create global constants for some of the protocol constants introduced with the block incentive mechanism.
Resolves #5998