-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Add GoMemLimit config option and use with 10-node test #5975
Conversation
…se it for 10 nodes * 1GB limit
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5975 +/- ##
=======================================
Coverage 56.00% 56.00%
=======================================
Files 481 481
Lines 67646 67648 +2
=======================================
+ Hits 37883 37887 +4
- Misses 27197 27200 +3
+ Partials 2566 2561 -5 ☔ View full report in Codecov by Sentry. |
test/e2e-go/features/partitionRecovery/partitionRecovery_test.go
Outdated
Show resolved
Hide resolved
…erCatchpointCatchup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a config option is reasonable enough, understanding we may want to later remove if Golang changes the expected behavior/approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but lets merge after p2p branch since it also adds v34 config, and rebasing this smaller PR will be easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well although feature/p2p has a conflict so requires manual remerge anyway, lets get it merged.
Summary
This adds a config option GoMemLimit for a soft memory limit like GOMEMLIMIT. It uses it for TestPartitionHalfOffline which runs 10 nodes (TenNodesDistributedMultiWallet.json) for 1GB each. It also uses it for TestSendSigsAfterCatchpointCatchup which starts 3 nodes and has one generate a catchpoint snapshot for the others.
Test Plan
TestPartitionHalfOffline should run 10 nodes without using as much memory, and TestSendSigsAfterCatchpointCatchup should also use less memory.