ledger: fix txtail restoring from catchpoints #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Catchpoints only have minimal data, and online accounts/txtail derive it when applying catchpoint * Deriving code is reused from migration the migration only assumed MaxTxnLife worth of block history * In fact, it need to restore MaxTxnLife + DeeperBlockHeaderHistory when used as part of catchpoint apply code path
cce
approved these changes
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #4460 +/- ##
==========================================
- Coverage 55.26% 55.23% -0.04%
==========================================
Files 398 398
Lines 50263 50264 +1
==========================================
- Hits 27780 27761 -19
- Misses 20167 20186 +19
- Partials 2316 2317 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jannotti
approved these changes
Aug 24, 2022
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Aug 25, 2022
* Catchpoints only have minimal data, and online accounts/txtail derive it by applying catchpoint * Deriving code is reused from DB schema migration but the migration only assumed MaxTxnLife worth of block history * In fact, it needs to restore MaxTxnLife + DeeperBlockHeaderHistory when used as part of catchpoint apply code path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when applying catchpoint
MaxTxnLife worth of block history
when used as part of catchpoint apply code path
Test Plan
Added new test: fails before the fix, works with the fix.