Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Add bn256 pairing opcodes experimentally #4013

Merged
merged 31 commits into from
May 24, 2022

Conversation

jannotti
Copy link
Contributor

Cleanups to allow merge of experimental pairing opcodes

Some doc tweaks, and moved implementation to pairing.go

These opcodes should stay in vFuture until

  1. We consider the deserialization format
  2. We have unit tests
  3. We consider BLS 12-381 (and the opcodes of eip 2537)
  4. Audit of gnark-crypto library

@jannotti jannotti requested a review from ahangsu May 19, 2022 17:52
@jannotti jannotti mentioned this pull request May 19, 2022
2 tasks
@jannotti jannotti changed the title Add bn256 experimentally AVM: Add bn256 pairing opcodes experimentally May 19, 2022
@jannotti
Copy link
Contributor Author

@bo-abstrlabs please have a look to confirm nothing you care about has changed.

Some doc tweaks, and moved implementation to pairing.go

These opcodes should stay in vFuture until

1. We consider the serialization format
2. We have unit tests
3. We consider BLS 12-381 (and the opcodes of eip 2537)
4. Audit of gnark-crypto library
@ahangsu
Copy link
Contributor

ahangsu commented May 19, 2022

seems langspec is conflicting with the doc.go?

nvm, seems we are updated with new commits...

@jannotti
Copy link
Contributor Author

seems langspec is conflicting with the doc.go?

nvm, seems we are updated with new commits...

ninja force push

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #4013 (847e0a9) into master (b3e19e7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4013      +/-   ##
==========================================
- Coverage   54.46%   54.42%   -0.04%     
==========================================
  Files         390      391       +1     
  Lines       48513    48570      +57     
==========================================
+ Hits        26421    26433      +12     
- Misses      19868    19915      +47     
+ Partials     2224     2222       -2     
Impacted Files Coverage Δ
data/transactions/logic/doc.go 60.00% <ø> (ø)
data/transactions/logic/opcodes.go 84.86% <ø> (ø)
data/transactions/logic/pairing.go 0.00% <0.00%> (ø)
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
ledger/acctupdates.go 68.77% <0.00%> (-0.66%) ⬇️
catchup/service.go 69.62% <0.00%> (+0.24%) ⬆️
network/wsPeer.go 68.88% <0.00%> (+0.83%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
util/metrics/counter.go 88.50% <0.00%> (+2.29%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e19e7...847e0a9. Read the comment docs.

ahangsu
ahangsu previously approved these changes May 19, 2022
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like most of the changes are actually in go-mod/go-sum, while the others are simply from #3655, looks good to me

@bo-abstrlabs
Copy link
Contributor

@jannotti Thanks. Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants