-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Add bn256 pairing opcodes experimentally #4013
Conversation
…runtime system cost
… and skip in TestReturnTypes
@bo-abstrlabs please have a look to confirm nothing you care about has changed. |
Some doc tweaks, and moved implementation to pairing.go These opcodes should stay in vFuture until 1. We consider the serialization format 2. We have unit tests 3. We consider BLS 12-381 (and the opcodes of eip 2537) 4. Audit of gnark-crypto library
nvm, seems we are updated with new commits... |
ninja force push |
Codecov Report
@@ Coverage Diff @@
## master #4013 +/- ##
==========================================
- Coverage 54.46% 54.42% -0.04%
==========================================
Files 390 391 +1
Lines 48513 48570 +57
==========================================
+ Hits 26421 26433 +12
- Misses 19868 19915 +47
+ Partials 2224 2222 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like most of the changes are actually in go-mod/go-sum, while the others are simply from #3655, looks good to me
@jannotti Thanks. Looks good to me! |
Cleanups to allow merge of experimental pairing opcodes
Some doc tweaks, and moved implementation to pairing.go
These opcodes should stay in vFuture until