Remove sig abstraction #3541
Merged
Remove sig abstraction #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id-ms
force-pushed
the
remove_sig_abstraction
branch
2 times, most recently
from
32c33e9 to
6117af6
Compare
added 2 commits
January 31, 2022 23:59
id-ms
force-pushed
the
remove_sig_abstraction
branch
from
6117af6 to
d86e14a
Compare
Aharonee
approved these changes
Feb 1, 2022
| _struct struct{} `codec:",omitempty,omitemptyarray"` | ||
| crypto.ByteSignature `codec:"bsig"` | ||
| _struct struct{} `codec:",omitempty,omitemptyarray"` | ||
| Signature crypto.FalconSignature `codec:"sig"` |
There was a problem hiding this comment.
This is a bit confusing to be honest. Why not just
crypto.FalconSignature `codec:"sig"`
as it was?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan