Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Changing golang version to 1.16.11 in go-algorand" #3506

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

algojack
Copy link
Contributor

Reverts #2825 to back out 1.16 golang update

Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question before I approve.

.github/workflows/reviewdog.yml Show resolved Hide resolved
Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's just how it was.

@onetechnical
Copy link
Contributor

Can you re-merge master? We have a separate change that should help the CI tests pass.

@onetechnical onetechnical self-requested a review January 26, 2022 14:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #3506 (9952b31) into master (762bc80) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3506      +/-   ##
==========================================
- Coverage   47.70%   47.56%   -0.15%     
==========================================
  Files         370      370              
  Lines       59857    60060     +203     
==========================================
+ Hits        28557    28569      +12     
- Misses      27986    28180     +194     
+ Partials     3314     3311       -3     
Impacted Files Coverage Δ
agreement/eventtype_string.go 2.32% <0.00%> (-31.01%) ⬇️
agreement/actiontype_string.go 5.00% <0.00%> (-28.34%) ⬇️
data/transactions/logic/fields_string.go 5.47% <0.00%> (-27.86%) ⬇️
agreement/statemachinetag_string.go 7.69% <0.00%> (-25.65%) ⬇️
agreement/coservicetype_string.go 0.00% <0.00%> (ø)
data/transactions/application_string.go 0.00% <0.00%> (ø)
agreement/pseudonode.go 71.69% <0.00%> (+0.75%) ⬆️
agreement/cryptoVerifier.go 75.17% <0.00%> (+7.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762bc80...9952b31. Read the comment docs.

@algojohnlee algojohnlee merged commit 1b32087 into master Jan 27, 2022
@algojohnlee algojohnlee deleted the revert-2825-jack/upgrade-golang-version-to-1.16.7 branch January 27, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants