Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate falcon scheme #3179

Conversation

id-ms
Copy link
Contributor

@id-ms id-ms commented Nov 2, 2021

Summary

Test Plan

@id-ms id-ms marked this pull request as ready for review November 2, 2021 20:33
@id-ms id-ms changed the title Integrate falcon scheme [WIP]Integrate falcon scheme Nov 2, 2021
@id-ms id-ms force-pushed the integrate-falcon-scheme branch 2 times, most recently from 9f2b0a6 to 98fc58e Compare November 2, 2021 22:44
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #3179 (42c6492) into feature/dilithium-scheme-integration (d9b945a) will increase coverage by 0.03%.
The diff coverage is 43.30%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/dilithium-scheme-integration    #3179      +/-   ##
========================================================================
+ Coverage                                 47.50%   47.54%   +0.03%     
========================================================================
  Files                                       375      376       +1     
  Lines                                     60217    60256      +39     
========================================================================
+ Hits                                      28606    28648      +42     
+ Misses                                    28321    28316       -5     
- Partials                                   3290     3292       +2     
Impacted Files Coverage Δ
cmd/goal/account.go 13.72% <0.00%> (-0.57%) ⬇️
libgoal/participation.go 0.00% <0.00%> (ø)
crypto/msgp_gen.go 36.35% <39.88%> (+0.99%) ⬆️
crypto/merklekeystore/keystore.go 74.68% <42.85%> (-2.24%) ⬇️
crypto/curve25519_wrapper.go 61.11% <50.00%> (ø)
crypto/invalidsigner.go 71.42% <50.00%> (+14.28%) ⬆️
crypto/falconWrapper.go 71.42% <71.42%> (ø)
crypto/merklekeystore/keystoreBuilder.go 76.74% <76.74%> (ø)
crypto/sig_abstractions.go 80.95% <83.33%> (-2.39%) ⬇️
data/account/participation.go 59.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b945a...42c6492. Read the comment docs.

@id-ms id-ms force-pushed the integrate-falcon-scheme branch 2 times, most recently from 2855c48 to b6f419a Compare November 4, 2021 11:45
@id-ms id-ms requested a review from algonautshant November 8, 2021 22:05
@id-ms id-ms force-pushed the integrate-falcon-scheme branch 2 times, most recently from af87a82 to 03192c9 Compare November 9, 2021 22:59
crypto/falconWrapper.go Outdated Show resolved Hide resolved
crypto/falconWrapper.go Show resolved Hide resolved
crypto/falconWrapper.go Show resolved Hide resolved
crypto/merklekeystore/keystoreBuilder.go Outdated Show resolved Hide resolved
crypto/merklekeystore/keystoreBuilder.go Outdated Show resolved Hide resolved
crypto/merklekeystore/keystoreBuilder.go Outdated Show resolved Hide resolved
crypto/merklekeystore/keystoreBuilder.go Outdated Show resolved Hide resolved
crypto/merklekeystore/keystoreBuilder.go Outdated Show resolved Hide resolved
crypto/merklekeystore/keystoreBuilder.go Outdated Show resolved Hide resolved
crypto/merklekeystore/keystoreBuilder.go Outdated Show resolved Hide resolved
@id-ms id-ms changed the title [WIP]Integrate falcon scheme Integrate falcon scheme Nov 12, 2021
@id-ms id-ms force-pushed the integrate-falcon-scheme branch from 7a0c0d9 to 7876ddd Compare November 12, 2021 18:18
Makefile Show resolved Hide resolved
cmd/goal/account.go Outdated Show resolved Hide resolved
cmd/goal/account.go Outdated Show resolved Hide resolved
@id-ms id-ms merged commit 674dba8 into algorand:feature/dilithium-scheme-integration Nov 16, 2021
@id-ms id-ms deleted the integrate-falcon-scheme branch October 25, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants