-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate falcon scheme #3179
Merged
id-ms
merged 22 commits into
algorand:feature/dilithium-scheme-integration
from
id-ms:integrate-falcon-scheme
Nov 16, 2021
Merged
Integrate falcon scheme #3179
id-ms
merged 22 commits into
algorand:feature/dilithium-scheme-integration
from
id-ms:integrate-falcon-scheme
Nov 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id-ms
force-pushed
the
integrate-falcon-scheme
branch
2 times, most recently
from
November 2, 2021 22:44
9f2b0a6
to
98fc58e
Compare
Codecov Report
@@ Coverage Diff @@
## feature/dilithium-scheme-integration #3179 +/- ##
========================================================================
+ Coverage 47.50% 47.54% +0.03%
========================================================================
Files 375 376 +1
Lines 60217 60256 +39
========================================================================
+ Hits 28606 28648 +42
+ Misses 28321 28316 -5
- Partials 3290 3292 +2
Continue to review full report at Codecov.
|
id-ms
force-pushed
the
integrate-falcon-scheme
branch
2 times, most recently
from
November 4, 2021 11:45
2855c48
to
b6f419a
Compare
id-ms
force-pushed
the
integrate-falcon-scheme
branch
2 times, most recently
from
November 9, 2021 22:59
af87a82
to
03192c9
Compare
algonautshant
suggested changes
Nov 10, 2021
id-ms
force-pushed
the
integrate-falcon-scheme
branch
from
November 12, 2021 18:18
7a0c0d9
to
7876ddd
Compare
stop all goroutines in case of an error
Error if the key range exist before generating the keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan