Fix encode bug+reduce type sized #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -307,20 +307,18 @@ func (stub *txGroupsEncodingStub) finishDeconstructTxnHeader() { | |||
|
|
|||
| func (stub *txGroupsEncodingStub) deconstructKeyregTxnFields(i int, txn *transactions.SignedTxn) { | |||
| bitmaskLen := bytesNeededBitmask(int(stub.TotalTransactionsCount)) | |||
| if !txn.Txn.VotePK.MsgIsZero() || !txn.Txn.SelectionPK.MsgIsZero() || txn.Txn.VoteKeyDilution != 0 { | |||
| if !txn.Txn.VotePK.MsgIsZero() || !txn.Txn.SelectionPK.MsgIsZero() || ((txn.Txn.StateProofPK.Root) != [merklekeystore.KeyStoreRootSize]byte{}) || txn.Txn.VoteKeyDilution != 0 { | |||
There was a problem hiding this comment.
I think that in this particular case, this one is safe during protocol upgrades, right ?
There was a problem hiding this comment.
I agree. this only checks that if some of the keys are not zeroed we need to allocate space
id-ms
force-pushed
the
fix-encode-bug+redue-type-sized
branch
from
e471283 to
c32ffff
Compare
Codecov Report
@@ Coverage Diff @@
## feature/dilithium-scheme-integration #3136 +/- ##
========================================================================
+ Coverage 43.51% 43.58% +0.07%
========================================================================
Files 402 402
Lines 90345 90506 +161
========================================================================
+ Hits 39315 39451 +136
- Misses 44686 44715 +29
+ Partials 6344 6340 -4
Continue to review full report at Codecov.
|
id-ms
force-pushed
the
fix-encode-bug+redue-type-sized
branch
6 times, most recently
from
6a72fc7 to
969f334
Compare
id-ms
force-pushed
the
fix-encode-bug+redue-type-sized
branch
2 times, most recently
from
8837d8c to
97195a8
Compare
id-ms
force-pushed
the
fix-encode-bug+redue-type-sized
branch
from
97195a8 to
7ee0c1a
Compare
id-ms
changed the title
algonautshant
approved these changes
Oct 26, 2021
algonautshant
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan