Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Deprecating use of langspec #366

Merged
merged 23 commits into from
Aug 26, 2022
Merged

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Aug 19, 2022

No description provided.

@ahangsu ahangsu force-pushed the deprecate-langspec branch from fef2c5c to 9a9da40 Compare August 23, 2022 16:39
.test-env Outdated Show resolved Hide resolved
@ahangsu ahangsu marked this pull request as ready for review August 24, 2022 14:10
logic/logic.go Outdated Show resolved Hide resolved
logic/logic.go Outdated Show resolved Hide resolved
Co-authored-by: Michael Diamant <[email protected]>
@ahangsu ahangsu requested a review from jasonpaulos August 25, 2022 14:20
@ahangsu ahangsu force-pushed the deprecate-langspec branch from f8dab81 to 2329b0e Compare August 25, 2022 18:59
crypto/account.go Outdated Show resolved Hide resolved
crypto/crypto.go Show resolved Hide resolved
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me, with the exception of one comment below.

I will come back and approve once the algorand-sdk-testing branch has been updated and that comment is resolved.

test/steps_test.go Outdated Show resolved Hide resolved
@ahangsu ahangsu requested a review from jasonpaulos August 26, 2022 15:41
@ahangsu ahangsu merged commit 4837c34 into develop Aug 26, 2022
@ahangsu ahangsu deleted the deprecate-langspec branch August 26, 2022 15:53
ahangsu added a commit that referenced this pull request Sep 2, 2022
* Github-Actions: Adding pr title and label checks (#336)

* Dev Tools: Source map decoder (#335)

* Updated CHANGELOG.md

* AVM:  Consolidate TEAL and AVM versions (#345)

* Testing: Use Dev mode network for cucumber tests (#349)

* AVM: Use avm-abi repo (#352)

* Updated CHANGELOG.md

* Enhancement: Use Sandbox for Testing (#360)

Co-authored-by: Michael Diamant <[email protected]>

* Bug-Fix: passthru verbosity (#371)

* Enhancement: Deprecating use of langspec (#366)

Co-authored-by: Michael Diamant <[email protected]>

* StateProof: State proof support (#374)

* Regenerate client.

* Update txn and block objects, cucumber tests passing.

* Enable cucumber tests.

* Update types/stateproof.go

* Add transactions-root-256

* Remove unused code.

* Remove unused file

* Add txn commitments blockheader fields

* Rename signature, add allocbound definitions

* Add txn commitment to header

* PR comments

* Remove unused file

Co-authored-by: Will Winder <[email protected]>

* State Proofs: Use generic type for StateProof txn field. (#378)

* Use generic type for StateProof txn field.

* Add missing type.

* Remove GenericDigest.

* fix type assertion on source map version (#370)

* let the json package figure out how to decode the elements of the incoming map (#380)

* StateProof: State Proof Verification additions (#377)

* Regenerate client.

* Remove unused file

* moved files from stateproof verification repo

* now using updated go-stateproof-verification

* fixed go mod

* moved consts near their usage

* added working state proof verifier test

* added unit test and resources

* now using go 1.15 supported function

* changes to avoid dependency of stateproof verification on SDK

* added needed types to stateproof.go for message hashing

* reverted packages, now using up to date go-stateproof-verification

* CR: renamed verification functions

* hashing sp message is now in crypto

* removed hashing of light block header

* CR: now allocating space upfront in hashing state proof message

* attempting to use embedded files

* CR: using GenericDigest in block.go

* CR: Renamed package to match directory

* Removed go 1.15 from CI

* improved embed usage

* CR: removed stateproof verification logic

* tidied go mod file

Co-authored-by: Will Winder <[email protected]>
Co-authored-by: Eric Warehime <[email protected]>

* State Proofs: added compute leaf function for light block header to sdk (#382)

* added compute leaf function for light block header to sdk

* renamed blockheader256

* changed passed type to pointer

* reverted back to copying

* renamed light block header hash func (#383)

* Enable stpf cucumber unit tests (#386)

Co-authored-by: Jack <[email protected]>
Co-authored-by: Ben Guidarelli <[email protected]>
Co-authored-by: Jack Smith <[email protected]>
Co-authored-by: Michael Diamant <[email protected]>
Co-authored-by: algochoi <[email protected]>
Co-authored-by: Jason Paulos <[email protected]>
Co-authored-by: Barbara Poon <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
Co-authored-by: Eric Warehime <[email protected]>
Co-authored-by: Will Winder <[email protected]>
Co-authored-by: Almog Tal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants