-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: graceful pipeline interrupt #97
Draft
tzaffi
wants to merge
37
commits into
algorand:master
Choose a base branch
from
tzaffi:graceful-interrupt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
b96486c
enhancement: plugin interface
bb68599
lint
543bcf5
commentary
aa9d310
tighten unit test expectations around importer.Init() *genesis return…
f80f9d4
fix plugin docs: https://developer.algorand.org/docs/get-details/cond…
8b60bc3
small edits
f75141a
Update .markdownlint.yml
tzaffi 650bdb7
cherry pick changes from docs-staleness branch
88d7b8f
Update .gitignore
tzaffi 274aebf
Update .gitignore
tzaffi 155e5ec
do we actually need the Config() method?
0e4d628
remove Config() everywhere
0eae647
remove Config() everywhere
9a3a95c
flatten PluginMetadata interface into Plugin interface
eb3e4fb
all the interfaces have Init() + importer has GetGenesis()
da2a27a
unify Init() inside of Plugin interface
7b36bde
Merge remote-tracking branch 'upstream/master' into plugin-interface
1301f19
fix unit tests that are supposed to error
f9f93b9
ErrorContains not Error()
d2fff8e
fix algod_importer tests
6863d42
Merge branch 'master' into plugin-interface
414d08d
md lint
4e41a97
handle interrupt signal
81c1b32
add round information to logs
ae6768b
Update conduit/metrics/metrics.go
tzaffi 92a503d
assert that the genesis is non-nil when no error getting it
948ac5b
Merge branch 'plugin-interface' into graceful-interrupt
80a51e3
atomically load the round as well
bcaa20c
per CR suggestion - more stopping signals
25c2478
revert carelessly introduced bug
b8fef8f
add in missing zero-val'd errInit and errGetGen
a4ffc01
Merge branch 'plugin-interface' into graceful-interrupt
d0a68c6
no for range needed
06c096c
Merge remote-tracking branch 'algorand/master' into graceful-interrupt
800bef7
fix bad merge
476faef
Update conduit/plugins/importers/algod/algod_importer.go
tzaffi 61ec15e
Update conduit/plugins/exporters/postgresql/postgresql_exporter.go
tzaffi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get the duplicate calls to plugins being closed because
Stop
is called twice. The other spot is inrunConduitCmdWithConfig
.Maybe the
cli
package is the right place to install a signal handler? We pass a context into the pipeline, when the context is cancelled maybe we should implicitly call stop (or maybe cancelling the context is Stop and we get rid of the public function)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've converted this PR into a draft and encapsulated its goals in new issue #100