-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix catchup error on first run and add retry forever option. #89
Conversation
Is this failing because the test needs updating or because the changes aren't correct? |
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 67.66% 69.09% +1.43%
==========================================
Files 32 36 +4
Lines 1976 2417 +441
==========================================
+ Hits 1337 1670 +333
- Misses 570 654 +84
- Partials 69 93 +24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I had one remaining question.
Co-authored-by: Zeph Grunschlag <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Two small changes:
Test Plan
Update unit tests.