Stale Docs #66
Closed
Stale Docs #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 67.66% 69.45% +1.79%
==========================================
Files 32 33 +1
Lines 1976 2118 +142
==========================================
+ Hits 1337 1471 +134
+ Misses 570 569 -1
- Partials 69 78 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
commented
May 1, 2023
Comment on lines
178
to
+186
| processors: | ||
| name: filter_processor | ||
| config: | ||
| filters: | ||
| - any: | ||
| - tag: txn.rcv | ||
| expression-type: exact | ||
| expression: "NVCAFYNKJL2NGAIZHWLIKI6HGMTLYXL7BXPBO7NXX4A7GMMWKNFKFKDKP4" | ||
| - name: filter_processor | ||
| config: | ||
| filters: | ||
| - any: | ||
| - tag: txn.rcv | ||
| expression-type: equal | ||
| expression: "NVCAFYNKJL2NGAIZHWLIKI6HGMTLYXL7BXPBO7NXX4A7GMMWKNFKFKDKP4" | ||
|
|
There was a problem hiding this comment.
Note to self: let's not merge this until I'm 100% sure that the filter is actually working as designed in my toy example.
|
Incorporating as parte of #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing typos and stale documentation.
Test Plan
CI - as no changes to actual code