Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: data dir & user permissions, install ca-certificates, better data dir location, more. #58

Merged
merged 13 commits into from
Apr 20, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Apr 20, 2023

Summary

This adds a number of small improvements over the first pass container:

  • Enable the docker release.
  • Better data dir / user permissions, similar to #5276.
  • Move data dir from /conduit/data to /data.
  • Install ca-certificates to allow using an algod provider service.

Testing

Similar to the previous docker PR: #50

Additional testing:

Mount data directory:

docker run -it --rm -v $(pwd)/local_data_dir:/data algorand/conduit:latest-snapshot-amd64

Check CMD overrides:

docker run -it --rm -v $(pwd)/local_data_dir:/data algorand/conduit:latest-snapshot-amd64 -h
docker run -it --rm -v $(pwd)/local_data_dir:/data algorand/conduit:latest-snapshot-amd64 init
docker run -it --rm -v $(pwd)/local_data_dir:/data algorand/conduit:latest-snapshot-amd64 list

@winder winder requested review from tzaffi, algochoi and a team April 20, 2023 12:07
@@ -30,11 +30,17 @@ jobs:
- name: Setup Docker Buildx (docker multi-arch dependency)
uses: docker/setup-buildx-action@v2

- name: dockerhub-login
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this deploy to docker hub every time a release tag is created? I'm not familiar with the frequency that this workflow is triggered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's been triggered once so far.

Dockerfile Show resolved Hide resolved
@algochoi
Copy link
Contributor

This works locally on my machine 👍

docker/docker-entrypoint.sh Outdated Show resolved Hide resolved
docs/Docker.md Show resolved Hide resolved
docs/Docker.md Outdated Show resolved Hide resolved
winder and others added 2 commits April 20, 2023 11:26
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOMM but some outstanding non-functional discussion points

docs/Docker.md Outdated Show resolved Hide resolved
docs/Docker.md Outdated Show resolved Hide resolved
Co-authored-by: Zeph Grunschlag <[email protected]>
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbroder-algo bbroder-algo merged commit d523bc4 into algorand:master Apr 20, 2023
@winder winder deleted the will/docker2 branch April 20, 2023 17:34
tzaffi pushed a commit that referenced this pull request May 8, 2023
…data dir location, more. (#58)

Improvements to the docker container and associated utilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants