-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: data dir & user permissions, install ca-certificates, better data dir location, more. #58
Conversation
@@ -30,11 +30,17 @@ jobs: | |||
- name: Setup Docker Buildx (docker multi-arch dependency) | |||
uses: docker/setup-buildx-action@v2 | |||
|
|||
- name: dockerhub-login |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this deploy to docker hub every time a release tag is created? I'm not familiar with the frequency that this workflow is triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's been triggered once so far.
This works locally on my machine 👍 |
Co-authored-by: Zeph Grunschlag <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOMM but some outstanding non-functional discussion points
Co-authored-by: Zeph Grunschlag <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…data dir location, more. (#58) Improvements to the docker container and associated utilities.
Summary
This adds a number of small improvements over the first pass container:
/conduit/data
to/data
.ca-certificates
to allow using an algod provider service.Testing
Similar to the previous docker PR: #50
Additional testing:
Mount data directory:
Check
CMD
overrides: