-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for devmode timestamps #275
Conversation
Scenario: Setting timestamp offsets in dev mode | ||
When I set the timestamp offset to be 1234 | ||
And I get the timestamp offset | ||
Then the timestamp offset should be 1234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is line 9 purely testing GET /v2/devmode/blocks/offset/
? If so, maybe it's also worth adding a step that calls GET v2/block/{round}
and verifies that the offset had the desired effect? Might be tricky to make it non-flaky though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just proposing an additional step (or two)
I don't think an integration test adds much safety here beyond whats already been done in the algod tests. What do you think about adding the path/response unit tests and calling it a day? For example: https://github.com/algorand/algorand-sdk-testing/pull/245/files |
I think some kind of E2E in |
Alternatively we could implement a full end to end test for devmode APIs for only one SDK (e.g. Python) under the |
Added path/response tests here: #276 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our previous conversations, I think this can be closed. Let me know if you disagree and we can discuss in person.
Sounds good, I'll close this for now. |
Adds tests for get/setting timestamp offsets in dev mode. Only confirms that the algod request/response is correct as a sanity check.
Example here: algorand/py-algorand-sdk#468