Feat/all ids are hashes #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file-content resp. to ensure reproducibility
saattrupdan
requested changes
Oct 4, 2023
Co-authored-by: Dan Saattrup Nielsen <[email protected]>
|
LGTM! Just need the tests to pass now. Seems like removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following potential bug:
recording_id's,speaker_id's for a given entity might change when rerunning thebuild_coral_data.py-script, due to these being assign concurrently. Now we create the ids as hashes of the recording, and the speaker name and mail respectively.We use the
adler32-hashing algorithm because its fast, produces short hashes, and has a low collision rate (even when truncating). Due to this last upside, we are able to truncate the hashes to produces equally long hashes every time. This way of producing ids is rather time-costly; atm running the script takes ~15 min...Note that some files are unable to be decoded, in which case we produce their id from their filename, which is still unique.
We also automatically generate a short readme pertaining to the processed data, as this was requested Anna (DIKU).