synthetic audio for nts data created by gTTS library #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be used as functions as well).
saattrupdan
requested changes
Aug 24, 2023
There was a problem hiding this comment.
Overall looks great! My comments are mostly some stylistic changes, as well as potentially converting some of the hardcoded values into arguments.
When this PR has been merged, we also need a PR which adds the following:
- Saving the dataset as a Hugging Face Dataset.
- Including a dataset config file which uses the dataset stored on Hugging Face Hub in the training script.
src/scripts/build_synthetic_nts.py
Outdated
| """ | ||
| subprocess.run(["say", text, "-o", filename]) | ||
|
|
||
| def generate_speech_eSpeak(text, filename, variant="+m1"): |
|
I see that there are also failures with the linting and unit testing that needs to be fixed here. Are you using the pre-commit hooks? |
fine. Co-authored-by: Dan Saattrup Nielsen <[email protected]>
Co-authored-by: Dan Saattrup Nielsen <[email protected]>
Co-authored-by: Dan Saattrup Nielsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates synthetic data from gTTS voice, the opensource library from Google with mit license.
It creates audio with the file name in the nts dataset and saves it in a train folder
Several other voices can be used to create data with this script, based on functions in the code (license should be investigated for these packages as e.g. espeak (needs to be installed, a terminal program) or mac build in voice with Siri Voices (needs to be a mac, obviously, a terminal program).
Issues, the folder structure probably wrong, some packages as click are not used in this code.
Should this code support code that are already made to create the nts dataset, which is not added now? Huggingface format is not implemented here.