Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw SSH key support, k0sctl.yaml config output, read phase retries #96

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

danielskowronski
Copy link

This is only a draft, but I wanted to let the community know that it's soon to be completed :)

Scope:

It can be tested with https://registry.terraform.io/providers/danielskowronski/k0s/

- add other option to pass SSH key - as raw PEM-encoded string alessiodionisi#94
- add k0sctlconfig as output, so it can be used with k0sctl CLI alessiodionisi#76
- handle situation, where k0s leader is not available - attempt to validate cluster on Read phase using all controllers
- investigate ways of actual node removal alessiodionisi#95
@alessiodionisi
Copy link
Owner

Thanks for the PR! I'll do a review within the next week.

@alessiodionisi alessiodionisi self-requested a review November 29, 2023 11:20
@alessiodionisi alessiodionisi marked this pull request as draft November 29, 2023 11:20
@alessiodionisi alessiodionisi changed the title [DRAFT] raw SSH key, k0sctlconfig, Read phase retries Raw SSH key support, k0sctl.yaml config output, read phase retries Nov 29, 2023
@danielskowronski
Copy link
Author

It won't be easy to implement #95 as issue seems to reside in k0sctl itself (k0sproject/k0sctl#603) plus some features were added but are not yet released with version number.

I'll try to figure out if some quick fix can be applied, e.g. by setting Reset flag dynamically on Read phase based upon detected need to rebuild the controller. But most likely it'll need to go out of scope of this PR and the relevant issue would wait for k0sctl implementation.

@alessiodionisi
Copy link
Owner

I prefer to wait k0sctl implementation, can you please rebase the PR? I can't do it because I can't commit to your branch.

@danielskowronski danielskowronski marked this pull request as ready for review January 2, 2024 11:45
@danielskowronski
Copy link
Author

I prefer to wait k0sctl implementation

We'll need to wait for k0sproject/k0sctl#603 and I assume it'd "just work". Otherwise, some logic would need to be applied as described previously.

Basically, k0sctl/k0s currently does not provide anything that a typical Terraform provider could use as a source of truth it can read at any given moment - for example, import operation can't be implemented from live cluster without any k0sctl.yaml file.

can you please rebase the PR? I can't do it because I can't commit to your branch.

Done

@Bugs5382
Copy link

Bugs5382 commented Dec 2, 2024

@alessiodionisi Any change you can merge this in an release it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants