-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw SSH key support, k0sctl.yaml config output, read phase retries #96
base: main
Are you sure you want to change the base?
Raw SSH key support, k0sctl.yaml config output, read phase retries #96
Conversation
- add other option to pass SSH key - as raw PEM-encoded string alessiodionisi#94 - add k0sctlconfig as output, so it can be used with k0sctl CLI alessiodionisi#76 - handle situation, where k0s leader is not available - attempt to validate cluster on Read phase using all controllers - investigate ways of actual node removal alessiodionisi#95
Thanks for the PR! I'll do a review within the next week. |
It won't be easy to implement #95 as issue seems to reside in k0sctl itself (k0sproject/k0sctl#603) plus some features were added but are not yet released with version number. I'll try to figure out if some quick fix can be applied, e.g. by setting |
I prefer to wait k0sctl implementation, can you please rebase the PR? I can't do it because I can't commit to your branch. |
We'll need to wait for k0sproject/k0sctl#603 and I assume it'd "just work". Otherwise, some logic would need to be applied as described previously. Basically, k0sctl/k0s currently does not provide anything that a typical Terraform provider could use as a source of truth it can read at any given moment - for example, import operation can't be implemented from live cluster without any
Done |
@alessiodionisi Any change you can merge this in an release it? |
This is only a draft, but I wanted to let the community know that it's soon to be completed :)
Scope:
key_path
#94It can be tested with https://registry.terraform.io/providers/danielskowronski/k0s/