New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing windows static libraries #340

Merged

alanxz merged 1 commit into alanxz:master from MiguelBarro:feature/windows_libstatic

Apr 10, 2024

Contributor

MiguelBarro commented Mar 21, 2024

Addressing several issues that prevented the build:

Util.h definitions didn't take into account the static library case. A new preprocessor definition was added and propagated to avoid __declspec statements on the static case.
CMake static library strategy doesn't allow intermediate merging (to avoid duplications surely) and forces the static dependencies to be propagated.
Dynamic linking to a static library doesn't make sense unless the dynamic library is a system/runtime one.


          Fixing windows static libraries

bec6afa

Signed-off-by: Guybrush <[email protected]>

MiguelBarro force-pushed the feature/windows_libstatic branch from 0eb8802 to bec6afa Compare

March 21, 2024 17:13

MiguelBarro marked this pull request as ready for review

March 21, 2024 17:23

alanxz merged commit eb876b9 into alanxz:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet