Issue192 paired symbols, issue199 yaml support #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 81.96% 81.89% -0.07%
==========================================
Files 107 108 +1
Lines 3166 3187 +21
==========================================
+ Hits 2595 2610 +15
- Misses 571 577 +6
|
alexeyinkin
suggested changes
May 11, 2023
alexeyinkin
reviewed
May 17, 2023
There was a problem hiding this comment.
We need two tests:
- A unit test to
InsertionCodeModiferwith1and23strings. - A test on
CodeControllerthat if created with the default parameters it handles all 6 pairs of characters.
alexeyinkin
suggested changes
Jun 6, 2023
| @@ -23,6 +23,10 @@ class PopupController extends ChangeNotifier { | |||
|
|
|||
| int get selectedIndex => _selectedIndex; | |||
|
|
|||
| void reset() { | |||
| itemScrollController = ItemScrollController(); | |||
There was a problem hiding this comment.
What is the desired effect of this? Scroll to the top? If so, can you manually scroll to the top?
Replacing the controller has the drawbacks:
- Need to dispose the old one.
- Need to make sure the disposed one will not show in a widget and break it.
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| test('inserts at the start of string correctly', () { |
There was a problem hiding this comment.
group('InsertionCodeModifier', ...
|
|
||
| void main() { | ||
| test('inserts at the start of string correctly', () { | ||
| const modifier = InsertionCodeModifier(openChar: '1', closeString: '23'); |
| const modifier = InsertionCodeModifier(openChar: '1', closeString: '23'); | ||
| const text = 'Hello World'; | ||
| final selection = TextSelection.fromPosition(const TextPosition(offset: 0)); | ||
| const editorParams = EditorParams(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #192
resolves #199
resolves #235