Trailing commas added to generated modes #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeyinkin
suggested changes
Apr 10, 2023
tool/src/porting.ts
Outdated
| @@ -67,7 +71,7 @@ export function generateMode( | |||
| code += `${k}: ${JSON.stringify(v)}`; | |||
| } | |||
|
|
|||
| if (i < arr.length - 1) { | |||
| if (i < arr.length) { | |||
There was a problem hiding this comment.
Can we just drop the condition?
alexeyinkin
reviewed
Apr 11, 2023
tool/src/porting.ts
Outdated
Comment on lines
61
to
65
| if (arr.length != 0) { | ||
| code += `${k}: [${arr.join(",")},]`; | ||
| break; | ||
| } | ||
| code += `${k}: []`; |
There was a problem hiding this comment.
Suggested change
| if (arr.length != 0) { | |
| code += `${k}: [${arr.join(",")},]`; | |
| break; | |
| } | |
| code += `${k}: []`; | |
| if (arr.length === 0) { | |
| code += `${k}: []`; | |
| break; | |
| } | |
| code += `${k}: [${arr.join(",")},]`; |
alexeyinkin
approved these changes
Apr 11, 2023
alexeyinkin
suggested changes
Apr 11, 2023
| "void", | ||
| "while", | ||
| "with", | ||
| "yield" |
There was a problem hiding this comment.
Keywords are dumped with JSON.stringify() which does not add trailing commas. We need a replacement to it that does. There must be 3rd party packages for this. This may also reduce special cases elsewhere, like arr.length === 0 in variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.