Enable triggering postcommit via specific file (apache#29549)

* Enable triggering postcommit via specific file

* address comments

* Add file path trigger approach and its context to Comment Triggering Support section

.github/build.gradle

@@ -28,6 +28,7 @@ buildscript {
 /** check that yml are valid */
 task check {
   doLast {
+    List<String> errors = []
     fileTree("${project.projectDir}/workflows").matching {
       include "*.yml"
       include "*.yaml"
@@ -36,23 +37,41 @@ task check {
       // attempt load yml to make sure its valid
       def workflow = new org.yaml.snakeyaml.Yaml().load(it.newInputStream())
 
-      // additional guards for running all tests functionality
-      // TODO(yathu) expand this also to post commits prior teardown Jenkins postcommits
-      if ( fname.startsWith("beam_PreCommit")) {
+      // additional guards to ensure tests configured in same way
+      if ( fname.startsWith("beam_PreCommit") || fname.startsWith("beam_PostCommit") ) {
         List paths
         try {
           paths = workflow.getAt(true).pull_request_target.paths as List
         } catch (Exception e) {
-          throw new GradleException("Fail to get the trigger path for ${fname}. " +
-                  "Make sure precommit has a pull_request_target trigger.", e)
+          errors.add("Fail to get the trigger path for ${fname}. " +
+                  "Make sure it has a pull_request_target trigger.")
+          return
         }
-        // precommit should triggered by this specific file
+
+        // precommit and postcommit should triggered by this specific file
+        // this is to ensure not missing test during release branch verification
         if (paths != null && !paths.contains('release/trigger_all_tests.json')) {
-          throw new GradleException("Error validating ${fname}: " +
-                  "Please add 'release/trigger_all_tests.json' to the trigger path for release verification run properly")
+          errors.add("Error validating ${fname}: " +
+                  "Please add 'release/trigger_all_tests.json' to the trigger path")
+          return
+        }
+
+        // postcommit should triggered by a specific file so that there is a way to exercise post for open PR
+        // TODO(https://github.com/apache/beam/issues/28909)
+        //  remove file match trigger once a better trigger (e.g. comment trigger) is implemented
+        if (fname.startsWith("beam_PostCommit")) {
+          String triggerFile = '.github/trigger_files/' + fname.take(fname.lastIndexOf('.')) + '.json'
+          if (paths != null && !paths.contains(triggerFile)) {
+            errors.add("Error validating ${fname}: " +
+                    "Please add ${triggerFile} to the trigger path")
+            return
+          }
         }
       }
     }
+    if (!errors.isEmpty()) {
+      throw new GradleException("Check failed: " + errors.join('\n'))
+    }
   }
 }
 

.github/workflows/beam_Java_JMH.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 0 * * 0'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_Java_JMH.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Go.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Go.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Go_Dataflow_ARM.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Go_Dataflow_ARM.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Go_VR_Flink.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Go_VR_Flink.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Go_VR_Samza.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Go_VR_Samza.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Go_VR_Spark.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Go_VR_Spark.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '0 5/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Avro_Versions.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Avro_Versions.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_BigQueryEarlyRollout.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_BigQueryEarlyRollout.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_DataflowV1.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_DataflowV1.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_DataflowV2.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '30 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_DataflowV2.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Examples_Dataflow.yml

@@ -21,7 +21,7 @@ on:
   schedule:
   - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Examples_Dataflow.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml

@@ -23,7 +23,7 @@ on:
   schedule:
     - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Examples_Dataflow_ARM.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Examples_Dataflow_Java.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Examples_Dataflow_Java.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Examples_Dataflow_V2.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Examples_Dataflow_V2.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Examples_Dataflow_V2_Java.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Examples_Dataflow_V2_Java.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Examples_Direct.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Examples_Direct.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Examples_Flink.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Examples_Flink.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Examples_Spark.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Examples_Spark.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Hadoop_Versions.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '45 3/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Hadoop_Versions.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml

@@ -21,7 +21,7 @@ on:
   schedule:
   - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_IO_Performance_Tests.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_InfluxDbIO_IT.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_InfluxDbIO_IT.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Jpms_Dataflow_Java11.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Jpms_Dataflow_Java11.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_Jpms_Dataflow_Java17.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Jpms_Dataflow_Java17.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_Jpms_Direct_Java11.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Jpms_Direct_Java11.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_Jpms_Direct_Java17.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Jpms_Direct_Java17.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_Jpms_Direct_Java21.yml

@@ -19,7 +19,7 @@ on:
   schedule:
   - cron: '0 */6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Jpms_Direct_Java21.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_Jpms_Flink_Java11.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Jpms_Flink_Java11.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_Jpms_Spark_Java11.yml

@@ -19,7 +19,7 @@ on:
   schedule:
     - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Jpms_Spark_Java11.json']
   workflow_dispatch:
 
 #Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event

.github/workflows/beam_PostCommit_Java_Nexmark_Dataflow.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '15 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Nexmark_Dataflow.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Nexmark_Dataflow_V2.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '15 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Nexmark_Dataflow_V2.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Nexmark_Dataflow_V2_Java.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '0 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Nexmark_Dataflow_V2_Java.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Nexmark_Direct.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '15 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Nexmark_Direct.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Nexmark_Flink.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '15 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Nexmark_Flink.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_Nexmark_Spark.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '15 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_Nexmark_Spark.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_PVR_Flink_Streaming.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '15 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_PVR_Flink_Streaming.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_PVR_Samza.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '15 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_PVR_Samza.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs

.github/workflows/beam_PostCommit_Java_PVR_Spark3_Streaming.yml

@@ -21,7 +21,7 @@ on:
   schedule:
     - cron: '15 4/6 * * *'
   pull_request_target:
-    paths: ['release/trigger_all_tests.json']
+    paths: ['release/trigger_all_tests.json', '.github/trigger_files/beam_PostCommit_Java_PVR_Spark3_Streaming.json']
   workflow_dispatch:
 
 # This allows a subsequently queued workflow run to interrupt previous runs