Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add generated line count to compare and commit pages #20

Merged
merged 18 commits into from
Jul 16, 2023
Merged

feat: Add generated line count to compare and commit pages #20

merged 18 commits into from
Jul 16, 2023

Conversation

aklinker1
Copy link
Owner

@aklinker1 aklinker1 commented Jul 15, 2023 •
edited
Loading

This closes #19.

  • Calculate diff for commit page
    Screenshot 2023-07-15 at 5 11 17 PM
  • Calculate diff for compare page (.. and ...)
    Screenshot 2023-07-15 at 5 11 24 PM
  • Show generated count on pages

Additionally, this PR refactors:

  • Break github/api.ts into service and API layers
  • Upgrades wxt to v0.2

@aklinker1 aklinker1 self-assigned this Jul 15, 2023
@aklinker1 aklinker1 added the enhancement New feature or request label Jul 15, 2023
aklinker1
aklinker1 commented Jul 15, 2023
View reviewed changes
src/entrypoints/content.ts
Comment on lines +7 to +8
// TODO: schedule next interval for 1 second AFTER the main function finishes. If the main
// function takes more than 1 second, it might cause problems.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@aklinker1 aklinker1 changed the title Compare and commit pages feat: Add generated line count to compare and commit pages Jul 15, 2023
@aklinker1 aklinker1 changed the title feat: Add generated line count to compare and commit pages feat: Add generated line count to compare and commit pages Jul 15, 2023
@aklinker1 aklinker1 marked this pull request as ready for review July 15, 2023 22:50
@aklinker1 aklinker1 mentioned this pull request Jul 15, 2023
Closed
@aklinker1 aklinker1 merged commit 24858be into main Jul 16, 2023
@aklinker1 aklinker1 deleted the compare-and-commit-pages branch July 16, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aklinker1 aklinker1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't work on commit and compare pages
1 participant
@aklinker1