Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the query for mint module #1118

Closed
wants to merge 2 commits into from

Conversation

carameleon
Copy link
Contributor


name: Pull Request
about: Submit a pull request
title: ''
labels: ''
assignees: '@boz @gosuri'


Description

Hello, I'm Jeonghwan in Cosmostation.

This PR will resolve the problem that query against mint module returns an error.

http://147.75.199.31:1317/cosmos/mint/v1beta1/inflation
http://147.75.199.31:1317/cosmos/mint/v1beta1/annual_provisions

returns

{
"code": 2,
"message": "panic message redacted to hide potentially sensitive system info: panic",
"details": []
}

I've tested on edgenet-6. (ATM, be running)

# this is my endpoint against edgenet-6
http://220.76.21.184:42001/cosmos/mint/v1beta1/inflation
http://220.76.21.184:42001/cosmos/mint/v1beta1/annual_provisions
{
"inflation": "0.131723718028706391"
}
{
"annual_provisions": "1335352871559435.801751235624843520"
}

reference : cosmos/cosmos-sdk#8426

Motivation and Context

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@carameleon carameleon changed the title update modules fix the query for mint module Feb 26, 2021
boz added a commit that referenced this pull request Mar 3, 2021
@hydrogen18
Copy link
Contributor

Due to a problem on our end, the tests always fail for this PR. @carameleon looks like this is fixed in #1121 that @boz opened. We appreciate your contribution and will close this PR at this time.

@hydrogen18 hydrogen18 closed this Mar 3, 2021
boz pushed a commit that referenced this pull request Mar 4, 2021
@boz
Copy link
Contributor

boz commented Mar 4, 2021

@carameleon, I set you as the author of the commit on the clean branch: 9e43756

Thank you so much for submitting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants